ci: fixing flaky CI#1302
Merged
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
kinyoklion
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will apply the same fix as we did for
.github/workflows/react.ymlto stablize the CI jobs.The underlying issue is that electron binary installation is expensive and would some times flake out. The fix here is to skip the binary setup for workflows that do not need it.
The reason this is a problem is that we need to do a
workspace ... installon contract test installations (asworkspaces focusdoes some funny things to non-prod dependencies that may interfere with building the contract tests). Unfortunately, inyarn,workspace... installdoes the same thing asyarn install(installs all deps).Note
Low Risk
Low risk CI-only change that alters dependency install environment for contract-test services; main risk is an unexpected package needing Electron in these jobs.
Overview
Reduces flakiness in the
server-nodeandshopify-oxygenGitHub Actions workflows by settingELECTRON_SKIP_BINARY_DOWNLOAD=1for the contract-test serviceyarn workspace ... installstep.This avoids unnecessary Electron binary downloads during CI installs while keeping the rest of the contract-test build and execution flow unchanged.
Reviewed by Cursor Bugbot for commit c320ff7. Bugbot is set up for automated code reviews on this repo. Configure here.